Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache GitHub requests #236

Merged
merged 3 commits into from
Sep 24, 2024
Merged

Cache GitHub requests #236

merged 3 commits into from
Sep 24, 2024

Conversation

benbc
Copy link
Contributor

@benbc benbc commented Sep 24, 2024

No description provided.

Copy link
Collaborator

@lucyb lucyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is nice.

It would be good to know why requests-cache was chosen over the other options. This could just be a description in the commit message, unless you feel it warrants an ADR.

This seems to be the least invasive way of avoiding the overhead of
calling the GitHub API when developing the metrics. The most obvious
alternative would be persistently-memoizing the functions in the `query`
module (e.g. with `cachier`), but that would require more code.
@benbc benbc merged commit 01deb5c into main Sep 24, 2024
9 checks passed
@benbc benbc deleted the benbc/cache-github-requests branch September 24, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants